From: Wolfram Schneider Date: Tue, 18 Mar 2014 09:51:27 +0000 (+0000) Subject: Merge branch 'master' of ssh://git.indexdata.com:222/home/git/private/mkws X-Git-Tag: 1.0.0~1314 X-Git-Url: http://sru.miketaylor.org.uk/?a=commitdiff_plain;h=7835a4302a611440bd3be646edbabbbe48cc745a;hp=132f1c9dd205f4bda88d54255dca1843b1981655;p=mkws-moved-to-github.git Merge branch 'master' of ssh://git.indexdata.com:222/home/git/private/mkws Conflicts: tools/htdocs/mkws-jquery.js --- diff --git a/test/spec/mkws-pazpar2.js b/test/spec/mkws-pazpar2.js index 76f4834..eff1c54 100644 --- a/test/spec/mkws-pazpar2.js +++ b/test/spec/mkws-pazpar2.js @@ -289,6 +289,13 @@ describe("Check Termlist", function () { $("div.mkwsFacetSources div.term:nth-child(" + source_number + ") a").trigger("click"); + // wait for a stat response + var waitcount = 0; + $(".mkwsPager").bind("DOMNodeInserted DOMNodeRemoved propertychange", function () { + waitcount++; + debug("DOM wait for stat: " + waitcount); + }); + waitsFor(function () { if ($("div.mkwsNavi").length && $("div.mkwsNavi").text().match(/(Source|datenquelle|kilder): /i)) { return true; @@ -300,13 +307,15 @@ describe("Check Termlist", function () { // Note: it may happens that limited source search returns the same number of hits // as before. Thats not really an error, but unfortunate waitsFor(function () { - return get_hit_counter() <= hits_all_targets ? true : false; + return waitcount >= 2 && get_hit_counter() <= hits_all_targets ? true : false; }, "Limited source search for less than " + hits_all_targets + " hits", 5 * jasmine_config.second); runs(function () { var hits_single_target = get_hit_counter(); debug("get less hits for sources: " + hits_all_targets + " > " + hits_single_target); expect(hits_all_targets).not.toBeLessThan(hits_single_target); + + $(".mkwsPager").unbind("DOMNodeInserted DOMNodeRemoved propertychange"); }); }); }); @@ -315,21 +324,28 @@ describe("Check Termlist", function () { describe("Check record list", function () { it("got a record", function () { var linkaddr = "div.mkwsRecords div.record:nth-child(1) a"; - var waitcount = 0; + var waitcount = 2; - // wait for new records - $("div.mkwsRecords").bind("DOMSubtreeModified propertychange", function () { +/* + // wait for new records, propertychange is for IE8 + $("div.mkwsRecords").bind("DOMNodeInserted propertychange", function () { + waitcount++; + debug("DOM DOMNodeInserted:" + waitcount + " " + $("div.mkwsRecords div.record").length); + }); + $("div.mkwsRecords").bind("DOMNodeRemoved", function () { waitcount++; - debug("DOM div.mkwsRecords changed"); + debug("DOM DOMNodeRemoved:" + waitcount + " " + $("div.mkwsRecords div.record").length); }); + */ waitsFor(function () { - return waitcount > 0 && $(linkaddr).length > 0; - }, "wait until we see a new record", 2.2 * jasmine_config.second); + // remove + insert node: must be at least 2 + return waitcount >= 2 && $(linkaddr).length > 0; + }, "wait until we see a new record: " + waitcount, 2.2 * jasmine_config.second); runs(function () { expect(waitcount).toBeGreaterThan(0); - $("div.mkwsRecords").unbind("DOMSubtreeModified"); + $("div.mkwsRecords").unbind("DOMNodeInserted DOMNodeRemoved"); }); }); }); @@ -344,8 +360,10 @@ describe("Show record", function () { // wait until the record pops up waitsFor(function () { var show = $("div.mkwsRecords div.record:nth-child(" + record_number + ") div"); + debug($("div.mkwsRecords div.record").text()); + return show != null && show.length ? true : false; - }, "wait some miliseconds to show up a record", 2 * jasmine_config.second); + }, "wait some miliseconds to show up a record", 4 * jasmine_config.second); runs(function () { debug("show record pop up"); diff --git a/tools/htdocs/mkws-jquery.js b/tools/htdocs/mkws-jquery.js index 0d10284..8e7102a 100644 --- a/tools/htdocs/mkws-jquery.js +++ b/tools/htdocs/mkws-jquery.js @@ -57,7 +57,9 @@ function _mkws_jquery_plugin ($) { // service-proxy or pazpar2 pazpar2: function(config) { - if (!config) config = {}; + if (config == null || typeof config != 'object') { + config = {}; + } var id_popup = config.id_popup || "#mkwsPopup"; id_popup = id_popup.replace(/^#/, "");