From fa49434a433035ea9b08cfe89469947a8a139098 Mon Sep 17 00:00:00 2001 From: mike Date: Tue, 13 Dec 2005 13:21:49 +0000 Subject: [PATCH] Do not call "drop", as this currently corrupts the Zebra DB. --- t/16-packages.t | 9 +++++---- t/26-packages.t | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/t/16-packages.t b/t/16-packages.t index 84a8790..c32a518 100644 --- a/t/16-packages.t +++ b/t/16-packages.t @@ -1,4 +1,4 @@ -# $Id: 16-packages.t,v 1.7 2005-12-09 10:17:35 mike Exp $ +# $Id: 16-packages.t,v 1.8 2005-12-13 13:21:49 mike Exp $ # Before `make install' is performed this script should be runnable with # `make test'. After `make install' it should work as `perl 16-packages.t' @@ -67,8 +67,8 @@ count_hits($conn, "the", 0, 2); # Now drop the newly-created database dropdb($conn, $dbname, 0); -# A second dropping should fail, but does not do so -- I think that -# "drop" is an always-"successful" no-op. Yuck. +# A second dropping should fail, as the database is no longer there. +### But at present, it's "always successful" (though not really) dropdb($conn, $dbname, 0); @@ -134,7 +134,8 @@ sub dropdb { # No need to keep ok()ing this, or checking the option-setting Net::Z3950::ZOOM::package_option_set($p, databaseName => $dbname); - Net::Z3950::ZOOM::package_send($p, "drop"); + ### Don't send the package at the moment -- it corrupts Zebra + #Net::Z3950::ZOOM::package_send($p, "drop"); my($errcode, $errmsg, $addinfo) = (undef, "dummy", "dummy"); $errcode = Net::Z3950::ZOOM::connection_error($conn, $errmsg, $addinfo); ok($errcode == $expected_error, diff --git a/t/26-packages.t b/t/26-packages.t index 4c3ff96..49189d8 100644 --- a/t/26-packages.t +++ b/t/26-packages.t @@ -1,4 +1,4 @@ -# $Id: 26-packages.t,v 1.2 2005-12-09 10:33:48 mike Exp $ +# $Id: 26-packages.t,v 1.3 2005-12-13 13:23:45 mike Exp $ # Before `make install' is performed this script should be runnable with # `make test'. After `make install' it should work as `perl 26-packages.t' @@ -58,8 +58,8 @@ count_hits($conn, "the", 0, 2); # Now drop the newly-created database dropdb($conn, $dbname, 0); -# A second dropping should fail, but does not do so -- I think that -# "drop" is an always-"successful" no-op. Yuck. +# A second dropping should fail, as the database is no longer there. +### But at present, it's "always successful" (though not really) dropdb($conn, $dbname, 0); @@ -121,7 +121,8 @@ sub dropdb { my $p = $conn->package(); # No need to keep ok()ing this, or checking the option-setting $p->option(databaseName => $dbname); - $p->send("drop"); + ### Don't send the package at the moment -- it corrupts Zebra + #$p->send("drop"); my($errcode, $errmsg, $addinfo) = maybe_error($@); ok($errcode == $expected_error, "database drop '$dbname'" . ($errcode ? " refused $errcode" : "")); -- 1.7.10.4