Do not return TEST_BAD when diagnostic is 1 (permanent system error).
authorMike Taylor <mike@indexdata.com>
Mon, 25 Mar 2013 18:04:20 +0000 (18:04 +0000)
committerMike Taylor <mike@indexdata.com>
Mon, 25 Mar 2013 18:04:20 +0000 (18:04 +0000)
commit887ada2b0c58be15e4e0551fd0cee8672c9fbdb1
tree5cf53bdee2b46a97c2829dab8d5c8b6f09ee2ff2
parent02ede4357cc423914351e11bb2e5c903252e8a50
Do not return TEST_BAD when diagnostic is 1 (permanent system error).
Fixes the second part of IR-338.

This probably needs some deeper thought. There seems to be some
uncertainty over whether returning TEST_BAD means "skip the rest of
this test" (which is what was intended here) or "skip this and all
sibling tests" (which is what's implemented). Do ANY instances of
TEST_BAD intend the latter? If not, we can just change the behaviour.
lib/ZOOM/IRSpy/Test/Search/Bib1.pm