From: Mike Taylor <mike@indexdata.com>
Date: Thu, 30 Nov 2006 12:01:23 +0000 (+0000)
Subject: Remove redundant _string2cdata() method, use xml_encode() instead.
X-Git-Tag: CPAN-v1.02~54^2~688
X-Git-Url: http://sru.miketaylor.org.uk/cgi-bin?a=commitdiff_plain;h=107a174e56c7b08f5401dd8d878fc143d93b879c;p=irspy-moved-to-github.git

Remove redundant _string2cdata() method, use xml_encode() instead.
---

diff --git a/lib/ZOOM/IRSpy/Record.pm b/lib/ZOOM/IRSpy/Record.pm
index 9141a51..a0738c8 100644
--- a/lib/ZOOM/IRSpy/Record.pm
+++ b/lib/ZOOM/IRSpy/Record.pm
@@ -1,4 +1,4 @@
-# $Id: Record.pm,v 1.20 2006-11-29 18:17:16 mike Exp $
+# $Id: Record.pm,v 1.21 2006-11-30 12:01:23 mike Exp $
 
 package ZOOM::IRSpy::Record;
 
@@ -98,7 +98,7 @@ sub store_result {
     my $xml = "<irspy:$type";
 
     foreach my $key (keys %info) {
-        $xml .= " $key=\"" . $this->_string2cdata($info{$key}) . "\"";
+        $xml .= " $key=\"" . xml_encode($info{$key}) . "\"";
     }
 
     $xml .= ">" . isodate(time()) . "</irspy:$type>\n";
@@ -158,21 +158,6 @@ sub _half_decent_appendWellBalancedChunk {
 }
 
 
-# Yes, I know that this is already implemented in IRSpy.pm. I suggest that we
-# introduce a toolkit package with such subroutines...
-#
-sub _string2cdata {
-    my ($this, $buffer) = @_;
-    $buffer =~ s/&/&amp;/gs;
-    $buffer =~ s/</&lt;/gs;
-    $buffer =~ s/>/&gt;/gs;
-    $buffer =~ s/"/&quot;/gs;
-    $buffer =~ s/'/&apos;/gs;
-
-    return $buffer;
-}
-
-
 =head1 SEE ALSO
 
 ZOOM::IRSpy