From: Mike Taylor <mike@indexdata.com>
Date: Tue, 7 Oct 2014 12:01:05 +0000 (+0100)
Subject: expandValue demoted from a member function to a private function.
X-Git-Tag: 1.0.0~292
X-Git-Url: http://sru.miketaylor.org.uk/cgi-bin?a=commitdiff_plain;h=d9069273e915794d963980f4d7222b371b196144;p=mkws-moved-to-github.git

expandValue demoted from a member function to a private function.
(It's never called outside of the widget object.)
---

diff --git a/src/mkws-widget.js b/src/mkws-widget.js
index 9a3a7f7..d57620b 100644
--- a/src/mkws-widget.js
+++ b/src/mkws-widget.js
@@ -66,8 +66,7 @@ function widget($, team, type, node) {
     return s.join('');
   };
 
-  // ### why is this a member function? It's never called from outside this file.
-  that.expandValue = function(val) {
+  function expandValue(val) {
     if (val.match(/^!param!/)) {
       var param = val.replace(/^!param!/, '');
       val = mkws.getParameterByName(param);
@@ -153,7 +152,7 @@ function widget($, team, type, node) {
 
   for (var i = 0; i < node.attributes.length; i++) {
     var a = node.attributes[i];
-    var val = that.expandValue(a.value);
+    var val = expandValue(a.value);
     if (a.name === 'data-mkws-config') {
       // Treat as a JSON fragment configuring just this widget
       log(node + ": parsing config fragment '" + val + "'");