From 4208d2ae922fa0d0d61fb14a5b69a10dfefba0fc Mon Sep 17 00:00:00 2001 From: Dennis Schafroth Date: Thu, 20 May 2010 15:14:28 +0200 Subject: [PATCH] Log fatal instead of crashing hard on wrongly configured metadata element. --- src/session.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/session.c b/src/session.c index 4910ea9..0c914ca 100644 --- a/src/session.c +++ b/src/session.c @@ -981,7 +981,10 @@ static int get_mergekey_from_doc(xmlDoc *doc, xmlNode *root, const char *name, if (!strcmp((const char *) n->name, "metadata")) { xmlChar *type = xmlGetProp(n, (xmlChar *) "type"); - if (!strcmp(name, (const char *) type)) + if (type == NULL) { + yaz_log(YLOG_FATAL, "Missing type attribute on metadata element. Skipping!"); + } + else if (!strcmp(name, (const char *) type)) { xmlChar *value = xmlNodeListGetString(doc, n->children, 1); if (value) -- 1.7.10.4